Studio: Clear out Site Health critical issue #562
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Automattic/dotcom-forge/issues/6652
Proposed Changes
This PR ensures that the
WP_AUTO_UPDATE_COREis not set tofalsewhen the WordPress version isuser-provided. As a result, the critical issue present underTools > Site Healthis not present on a newly created Studio site anymore.Testing Instructions
nvm use && npm install && npm startAdd siteformTools > Site HealthNotes:
WP_AUTO_UPDATE_COREis set tofalseis because we are passinguser-providedinstead ofuser-definedon this line:studio/vendor/wp-now/src/wp-now.ts
Line 266 in dc061f3
Pre-merge Checklist