Skip to content

i18n: Make aria-label text translatable #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SiobhyB merged 1 commit into from
Apr 28, 2024
Merged

i18n: Make aria-label text translatable #53

SiobhyB merged 1 commit into from
Apr 28, 2024

Conversation

@t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Apr 28, 2024 •
edited
Loading

Proposed Changes

I noticed that the text in the following three places is not translatable.

Global

global

Offline Indicator

offline-indicator

Sites

sites

Testing Instructions

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@SiobhyB SiobhyB self-requested a review April 28, 2024 06:34
SiobhyB
SiobhyB approved these changes Apr 28, 2024
View reviewed changes
Copy link

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting and fixing these @t-hamano! 🙌

@SiobhyB SiobhyB merged commit be4c50e into Automattic:trunk Apr 28, 2024
@t-hamano t-hamano deleted the i18n/translate-aria-label branch April 30, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SiobhyB SiobhyB SiobhyB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@t-hamano t-hamano

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-hamano @SiobhyB