-
Notifications
You must be signed in to change notification settings - Fork 53
Switch "Local path" field to copy button instead of open new button #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@matt-west It seems odd that "copy" is the default behavior for the other fields: What do you think about making "copy" the default behavior for this field too, and then using an "open in new window" icon for opening the file path? |
|
@danielbachhuber Yep, that works. Thanks for the suggestion! |
|
@danielbachhuber @matt-west Studio already provides a way to open a directory in the Overview tab, 'Open in...' -> 'Finder' option. What if we make it consistent in the Settings tab and use the copy action for all listed items, ditching the open action there? |
@wojtekn I'm amenable to this. I tried using the copy button and then open new, but it looked funky when you clicked the button and "Copied!" appeared. |
|
Thanks @danielbachhuber. Yes, I agree that two buttons together could be confusing there. |
|
Do you think users will need to copy the local path more than they want to open the folder in Finder? I agree that we can simplify to one action here. Copying makes sense for the other items in settings as it's things like passwords, URLs, and username. I’m not yet convinced that it needs to be the primary action for local path though. Can you share some example of when users will need to copy the path as text. |
They can open the folder in the Overview tab.
Now, users need to open the Terminal and run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove no longer used imports - Icon, file, getIpcApi, and Button.
This is what I ran into. I'm not sure of a use case to open the site's directory in the Finder, to be honest. |
I use that occasionally to edit or delete files or review the site content quickly. I think that with your change, the UI is clearer as:
|
|
Thanks for the additional info. Happy to drop the folder icon and go with the copy action instead. 👍 I’ve updated the designs in Figma to reflect the change. |

Proposed Changes
Switches the "Local path" field to use a copy button instead of open new button.
Before:
After:
Testing Instructions
Pre-merge Checklist