feat: Minimize site form layout shift #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Add site" dialog relies upon asynchronous name generation, which ultimately populates the site path input. Conditionally rendering the site path input based upon the populated site path value meant the input popped into place during the modal open animation. Conditionally rendering the input based upon the event handler only ensures the input is present throughout the modal open animation.
Member
Author
|
I consider the proposed changes an easy, low-quality solution, but I feel they are sufficient for the time being. A more ideal solution might involve rendering a placeholder until the asynchronous work is complete. We might also postpone rendering of the actual dialog content until after both the modal open animation and asynchronous name generation complete to achieve optimal FPS. |
katinthehatsite
approved these changes
Jun 25, 2024
Contributor
katinthehatsite
left a comment
katinthehatsite
left a comment
There was a problem hiding this comment.
The changes look good and fix the issue for me. Thanks for adding the fix!
fluiddot
pushed a commit
that referenced
this pull request
Jun 27, 2024
The "Add site" dialog relies upon asynchronous name generation, which ultimately populates the site path input. Conditionally rendering the site path input based upon the populated site path value meant the input popped into place during the modal open animation. Conditionally rendering the input based upon the event handler only ensures the input is present throughout the modal open animation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Minimize site form layout shift
The "Add site" dialog relies upon asynchronous name generation, which
ultimately populates the site path input. Conditionally rendering the
site path input based upon the populated site path value meant the input
popped into place during the modal open animation. Conditionally
rendering the input based upon the event handler only ensures the input
is present throughout the modal open animation.
Testing Instructions
Tip
Observing the difference in the provided screen recordings below requires slowly dragging the video scrubber.
initial-open-before.mov
initial-open-after.mov
repeat-open-after.mov
1. Add site dialog always displays site path input
animation the first time the modal is opened.
2. Edit site name excludes site path input
Pre-merge Checklist