feat: Improve dialog messaging consistency #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other dialogs allowing permanent dismissal rely upon the same message, except for this one instance. Consistently using the same phrasing increases user familiarity with and confidence in the product.
katinthehatsite
approved these changes
Jun 24, 2024
Contributor
katinthehatsite
left a comment
katinthehatsite
left a comment
There was a problem hiding this comment.
The changes look good 👍 Thanks for making the improvement!
Member
Author
|
Merged this small message string change with the approval. @matt-west please let me know if you'd prefer a different approach. See #287 (comment) for additional context. I'm happy to follow up on any requests. |
Contributor
|
Looks good. Thanks @dcalhoun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #287 (comment).
Proposed Changes
All other dialogs allowing permanent dismissal rely upon the same
message, except for this one instance. Consistently using the same
phrasing increases user familiarity with and confidence in the product.
Testing Instructions
Pre-merge Checklist