Skip to content

Conversation

@sejas
Copy link
Member

@sejas sejas commented Dec 4, 2025

Related issues

Proposed Changes

  • Align skip button in Authentication onboarding screen
  • Unify the translation string to include the arrow

Testing Instructions

  • Remove sites
  • Log out
  • Edit your "onboardingCompleted": false,
  • Run npm start
  • Confirm the skip button is correctly aligned
Before After
Screenshot 2025-12-04 at 11 19 46 Screenshot 2025-12-04 at 11 15 11

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas self-assigned this Dec 4, 2025
@sejas sejas requested a review from a team December 4, 2025 11:20
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

📊 Performance Test Results

Comparing 8b1309d vs trunk

site-editor

Metric trunk 8b1309d Diff Change
load 9631.00 ms 13290.00 ms +3659.00 ms 🔴 38.0%

site-startup

Metric trunk 8b1309d Diff Change
siteCreation 22627.00 ms 23482.00 ms +855.00 ms 🔴 3.8%
siteStartup 7037.00 ms 8989.00 ms +1952.00 ms 🔴 27.7%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

The changes look good 👍

@sejas sejas merged commit a9f1e98 into trunk Dec 4, 2025
9 checks passed
@sejas sejas deleted the update/stu-1097-align-skip-button-in-authentication-onboarding branch December 4, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants