Update alert and tooltip after uploading push backup #2182
Conversation
📊 Performance Test ResultsComparing 2a9fff8 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
epeicher
left a comment
epeicher
left a comment
There was a problem hiding this comment.
Thanks @sejas for improving this! These changes better inform the user that it is safe to close Studio when the Push is running on the server. I have tested it, and it works as expected. I can see the tooltip and dialog with the updated text. LGTM! 
| Tooltip cancellable push | Dialog cancellable push | Tooltip push continuing | Dialog push continuing |
|---|---|---|---|
 |
 |
 |
 |
src/index.ts
Outdated
| : { | ||
| message: __( 'Sync will continue' ), | ||
| detail: __( | ||
| 'The sync process will continue on the server side even after you quit Studio. We will send you an email when it is complete.' |
There was a problem hiding this comment.
I am wondering if server side is clear enough, I suggest for consideration
The sync process will continue on our servers even after you quit Studio. We will send you an email when it is complete.
But that is just a suggestion, feel free to keep the current one
There was a problem hiding this comment.
Alternatively, we can also say something like The sync process will continue running remotely after you quit Studio. We will send you an email when it is complete.
| pushBackupIsUploading( pushState?.status.key ) | ||
| ? __( 'Push is in progress. We will send you an email when it is completed.' ) | ||
| : __( | ||
| "The push is in progress and will continue in the backend. We will send you an email once it's completed." |
There was a problem hiding this comment.
| "The push is in progress and will continue in the backend. We will send you an email once it's completed." | |
| "The push is in progress and will continue running. We will send you an email once it's completed." |
I am just wondering if backend is the easiest wording to understand for users so suggesting a slightly simpler alternative.
There was a problem hiding this comment.
I changed it to The push is in progress and will continue running remotely. We will send you an email once it's completed. in 4da6eea
katinthehatsite
left a comment
katinthehatsite
left a comment
There was a problem hiding this comment.
The functionality looks good to me, I added some minor suggestions for wording.
sejas
deleted the
update/stu-890-studio-improve-sync-push-tooltip-and-alert
branch
Related issues
Proposed Changes
We want to let users know that it's safe to close Studio while the server is applying changes.
Testing Instructions
npm startsync-alert-and-tooltip-updated.mp4
Pre-merge Checklist