Skip to content

Studio: Add translations for Playground CLI console messages during site creation #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
epeicher merged 2 commits into from
Nov 24, 2025
Merged

Studio: Add translations for Playground CLI console messages during site creation #2110

epeicher merged 2 commits into from
Nov 24, 2025

Conversation

@epeicher
Copy link
Contributor

@epeicher epeicher commented Nov 21, 2025 •
edited
Loading

Related issues

Proposed Changes

  • Updated formatMessageForUI() function to wrap all user-facing console messages with translation calls

Testing Instructions

  • Change your system language to a non-English language that Studio supports (e.g., Spanish, French, German, Polish). Please note that most of the strings need to be translated
  • Create a new site in Studio
  • Observe the loading messages that appear during site creation
  • Verify that the console messages are displayed in the selected language instead of English

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@epeicher epeicher self-assigned this Nov 21, 2025
@epeicher epeicher marked this pull request as ready for review November 21, 2025 16:43
@epeicher epeicher requested a review from a team November 21, 2025 16:48
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025 •
edited
Loading

📊 Performance Test Results

Comparing 04dd593 vs trunk

site-editor

Metric trunk 04dd593 Diff Change
load 16161.00 ms 15279.00 ms -882.00 ms 🟢 -5.5%

site-startup

Metric trunk 04dd593 Diff Change
siteCreation 34530.00 ms 29640.00 ms -4890.00 ms 🟢 -14.2%
siteStartup 11125.00 ms 12137.00 ms +1012.00 ms 🔴 9.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

bcotrim
bcotrim approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@bcotrim bcotrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I couldn't see the translation yet, but I can see the new messages in english

Image

@wojtekn
Copy link
Contributor

wojtekn commented Nov 24, 2025 •
edited
Loading

@epeicher , would it make sense to add an inline code comment referencing the Playground CLI source to make any future updates to that easier?

@epeicher epeicher merged commit e411387 into trunk Nov 24, 2025
9 checks passed
@epeicher epeicher deleted the stu-981-missing-translations-for-steps-displayed-when-adding-site branch November 24, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wojtekn wojtekn wojtekn approved these changes

@bcotrim bcotrim bcotrim approved these changes

Assignees

@epeicher epeicher

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@epeicher @wojtekn @bcotrim