Skip to content

Studio: Update Stepper component styles for consistency with designs #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavande1 merged 2 commits into from
Nov 7, 2025
Merged

Studio: Update Stepper component styles for consistency with designs #2016

gavande1 merged 2 commits into from
Nov 7, 2025

Conversation

@gavande1
Copy link
Contributor

@gavande1 gavande1 commented Nov 5, 2025 •
edited
Loading

Related issues

Proposed Changes

  • Update designs to match Figma ( RToz6tIuQ7nlZrikBte4GU-fi-9848_68300 )

Testing Instructions

  • Check out this branch
  • Start Studio using npm start
  • Click on Add site
  • Select Start from a Blueprint
  • Compare the Steps with the designs.
CleanShot 2025-11-05 at 18 00 17@2x

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@gavande1 gavande1 self-assigned this Nov 5, 2025
@gavande1 gavande1 requested review from a team and Marinatsu November 5, 2025 12:31
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

📊 Performance Test Results

Comparing d88387d vs trunk

site-editor

Metric trunk d88387d Diff Change
load 12634.00 ms 14688.00 ms +2054.00 ms 🔴 16.3%

site-startup

Metric trunk d88387d Diff Change
siteCreation 16131.00 ms 17143.00 ms +1012.00 ms 🔴 6.3%
siteStartup 4982.00 ms 5048.00 ms +66.00 ms 🔴 1.3%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

bcotrim
bcotrim approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@bcotrim bcotrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ivan-ottinger
ivan-ottinger approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks much better to me than before (with less thick fonts):

Image

gcsecsey
gcsecsey approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@gcsecsey gcsecsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Before After
Image Image

@gavande1 gavande1 merged commit a0b21ef into trunk Nov 7, 2025
11 checks passed
@gavande1 gavande1 deleted the stu-860-studio-blueprints-stepper branch November 7, 2025 11:10
@gavande1
Copy link
Contributor Author

gavande1 commented Nov 7, 2025

@Marinatsu, I have deployed this after getting a review from the team. If you still feel there is something that needs to be done, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcotrim bcotrim bcotrim approved these changes

@gcsecsey gcsecsey gcsecsey approved these changes

@ivan-ottinger ivan-ottinger ivan-ottinger approved these changes

@Marinatsu Marinatsu Awaiting requested review from Marinatsu

Assignees

@gavande1 gavande1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gavande1 @bcotrim @gcsecsey @ivan-ottinger