Studio: Be more specific in push success email by listing individual sync elements #2007
Conversation
…ecific-data-to-backend-for-email
📊 Performance Test ResultsComparing 541a3e0 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
sejas
left a comment
sejas
left a comment
There was a problem hiding this comment.
@katinthehatsite , it works great! I tested it the PR with the backend PR 195447-ghe-Automattic/wpcom . However I noticed that we are sending paths option, which I believe is not necessary. In that case I also suggest renaming the include_path_list param to avoid confusion with a valid param that uses VaultPress.
…ecific-data-to-backend-for-email
There was a problem hiding this comment.
Thanks for removing the unused paths option and renaming the param from include_path_list to list_sync_items.
I tested it and it works as expected. I received the email displaying the selected items.
While testing the PR, I found an issue, but it's also present on trunk, so let's fix it separately in STU-1003.
Let's rebase onto trunk and make sure the CI passes.
…ecific-data-to-backend-for-email
katinthehatsite
deleted the
fix/send-specific-data-to-backend-for-email
branch
Related issues
Closes STU-759
Proposed Changes
Testing Instructions
Pre-merge Checklist