-
Notifications
You must be signed in to change notification settings - Fork 53
Unify selective push and export logic #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📊 Performance Test ResultsComparing 8a701ae vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
| const stat = fs.statSync( fullPath ); | ||
| const stat = await fsPromises.stat( fullPath ); | ||
| if ( stat.isDirectory() ) { | ||
| this.archiveBuilder.directory( fullPath, archivePath ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simplification 👍
katinthehatsite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, different test cases worked well 👍
Related issues
Proposed Changes
sqlite-database-integrationis excluded and all the wp-content data is included.Testing Instructions
Test selective push
npm startmu-pluginssqlite-database-integrationis not included in the zip file.test-push.mp4
Test export database and full export
npm starttest-exports.mp4
Pre-merge Checklist