Skip to content

Add Survey to What's New modal #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bcotrim merged 3 commits into from
Oct 30, 2025
Merged

Add Survey to What's New modal #1973

bcotrim merged 3 commits into from
Oct 30, 2025
+85 −97

Conversation

@bcotrim
Copy link
Contributor

@bcotrim bcotrim commented Oct 30, 2025

Related issues

Proposed Changes

  • Add survey to "What's New" modal
  • Add a new option to set a custom link label
image

Testing Instructions

  • Start Studio
  • Open "What's New" modal
  • Confirm the survey entry exists and follows design
  • Confirm the link opens the survey

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@bcotrim bcotrim requested a review from a team October 30, 2025 09:27
@bcotrim bcotrim self-assigned this Oct 30, 2025
ivan-ottinger
ivan-ottinger approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The code change looks good and the survey card displays correctly. The "Take the survey" link works as well. 👌🏼

Screen Shot on 2025-10-30 at 10:37:08

What if we removed one of the older cards at the same time? Maybe the "Choose your preferred apps" could go.

@bcotrim
Copy link
Contributor Author

bcotrim commented Oct 30, 2025

thanks for the review and suggestion @ivan-ottinger
I removed the entry in ebbad7b

@ivan-ottinger
Copy link
Contributor

ivan-ottinger commented Oct 30, 2025

thanks for the review and suggestion @ivan-ottinger
I removed the entry in ebbad7b

Thank you, Bernardo!

We could also remove the related preferredAppsIllustration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025 •
edited
Loading

📊 Performance Test Results

Comparing 08ea3bc vs trunk

site-editor

Metric trunk 08ea3bc Diff Change
load 10966.00 ms 17116.00 ms +6150.00 ms 🔴 56.1%

site-startup

Metric trunk 08ea3bc Diff Change
siteCreation 17177.00 ms 19118.00 ms +1941.00 ms 🔴 11.3%
siteStartup 5991.00 ms 6010.00 ms +19.00 ms 🔴 0.3%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

epeicher
epeicher approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bcotrim for implementing this! I have tested it, and it works as advertised. LGTM! :shipit:

Image

@wojtekn
Copy link
Contributor

wojtekn commented Oct 30, 2025

Looks good!

I tested the survey, too, and shared thoughts under WPBRAND-243.

@bcotrim bcotrim merged commit 3a3c17e into trunk Oct 30, 2025
12 checks passed
@bcotrim bcotrim deleted the stu-916-studio-add-survey-to-whats-new-modal branch October 30, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wojtekn wojtekn wojtekn approved these changes

@epeicher epeicher epeicher approved these changes

@ivan-ottinger ivan-ottinger ivan-ottinger approved these changes

Assignees

@bcotrim bcotrim

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bcotrim @ivan-ottinger @wojtekn @epeicher