Skip to content

Update deleted sync site UI #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nightnei merged 6 commits into from
Oct 28, 2025
Merged

Update deleted sync site UI #1942

nightnei merged 6 commits into from
Oct 28, 2025

Conversation

@nightnei
Copy link
Contributor

@nightnei nightnei commented Oct 27, 2025 •
edited
Loading

Proposed Changes

When a site was deleted in wpcom, we render not specific message, so I propose:

  1. Say that the site was most likely deleted
  2. Render site url, since now we have only site name. Also make site url clickable, so that user can open and quickly access that site to check what is wrong.

Testing Instructions

  1. Create wpcom site
  2. In Studio, open Sync tab and connect it
  3. Delete that site in wpcom
  4. Open Sync tab again
  5. Assert that you see the new message
BEFORE AFTER
Screenshot 2025-10-27 at 17 07 46 Screenshot 2025-10-27 at 17 06 16
  1. Click on site name
  2. Assert that you we redirected to that site and see the message:
    Screenshot 2025-10-27 at 17 08 36

@nightnei nightnei requested a review from a team October 27, 2025 17:09
@nightnei nightnei self-assigned this Oct 27, 2025
@nightnei nightnei changed the title Untangling prod and staging sites Update deleted sync site message Oct 27, 2025
@nightnei nightnei changed the title Update deleted sync site message Update deleted sync site UI Oct 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025 •
edited
Loading

📊 Performance Test Results

Comparing 65f1579 vs trunk

site-editor

Metric trunk 65f1579 Diff Change
load 10031.00 ms 13132.00 ms +3101.00 ms 🔴 30.9%

site-startup

Metric trunk 65f1579 Diff Change
siteCreation 22625.00 ms 23193.00 ms +568.00 ms 🔴 2.5%
siteStartup 8061.00 ms 6008.00 ms -2053.00 ms 🟢 -25.5%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

epeicher
epeicher approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nightnei for improving this! I have tested it, and I can see the URL and the new message, which I agree is more informative.

One small improvement I would try is to style the URL link with the same blue than the Get help to indicate that is a link, as I didn't realize that it was clickable until hovering over it. But apart from that, this LGTM!

Studio Calypso
Image Image

@nightnei
Copy link
Contributor Author

nightnei commented Oct 28, 2025

One small improvement I would try is to style the URL link with the same blue than the Get help to indicate that is a link, as I didn't realize that it was clickable until hovering over it.

@epeicher great point 👍 Adjusted

Base automatically changed from add/untanglingProdAndStagingSites to trunk October 28, 2025 10:56
@nightnei nightnei merged commit 097521e into trunk Oct 28, 2025
12 checks passed
@nightnei nightnei deleted the update/deletedSyncSiteMessage branch October 28, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epeicher epeicher epeicher approved these changes

Assignees

@nightnei nightnei

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nightnei @epeicher