Expired previews are not getting deleted #1909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 7, 2025 16:56
…ttic/studio into fix/expired-preview-sites-removal
…ttic/studio into fix/expired-preview-sites-removal
Contributor
📊 Performance Test ResultsComparing b5dd97a vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
gcsecsey
approved these changes
Oct 21, 2025
Contributor
gcsecsey
left a comment
gcsecsey
left a comment
There was a problem hiding this comment.
Thanks @katinthehatsite, this looks good and works well for me. 👍
I already had a couple expired preview sites:
After clearing "My Elementor Website Preview 1":
After restarting the app:
The preview is also removed from appdata-v1.json:
wojtekn
approved these changes
Oct 21, 2025
Contributor
wojtekn
left a comment
wojtekn
left a comment
There was a problem hiding this comment.
It fixes the issue - cleared previews do not appear in my Studio again.
nightnei
approved these changes
Oct 21, 2025
Contributor
nightnei
left a comment
nightnei
left a comment
There was a problem hiding this comment.
LGTM and works as expected (I had real expired site) 👍
Co-authored-by: Volodymyr Makukha <[email protected]>
…-preview-sites-removal
…ttic/studio into fix/expired-preview-sites-removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes STU-859
Proposed Changes
This PR ensures that when you are clicking on the
Clearbutton to remove an expired preview site from the UI, it is removed correctly from app-data and does not show back in the UI on app rerendering.Testing Instructions
/Library/Application Support/Studio/appdata-v1.jsonfile and set that preview site to be created 10 days agoPreviewsand observe that the preview site is marked as expired in the UIClearbuttonappdata-v1.jsonPre-merge Checklist