Skip to content

Studio: Fix classic theme Customize links for Menus and Widgets #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sejas merged 1 commit into from
Oct 13, 2025
Merged

Studio: Fix classic theme Customize links for Menus and Widgets #1873

sejas merged 1 commit into from
Oct 13, 2025

Conversation

@bcotrim
Copy link
Contributor

@bcotrim bcotrim commented Oct 10, 2025 •
edited
Loading

Related issues

Proposed Changes

  • Fixed theme details fetching to ensure WordPress is fully initialized before reading theme features
  • Simplified theme details logic by always using runPhp method instead of mu-plugin endpoint
  • Removed unused get_theme_details action from mu-plugins

Testing Instructions

  • Create a new site with a classic theme (e.g., Twenty Twenty-One or Seedlet)
  • Start the site and navigate to the Overview tab
  • Verify the theme information displays correctly
  • Check that "Customize Menus" and "Customize Widgets" links appear in the Customize section
  • Click on the Customize links to verify they work correctly
  • Test with both classic themes and block themes

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@bcotrim bcotrim self-assigned this Oct 10, 2025
@bcotrim bcotrim requested a review from a team October 10, 2025 15:58
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

📊 Performance Test Results

Comparing 2afcabe vs trunk

site-editor

Metric trunk 2afcabe Diff Change
load 10575.50 ms 12515.50 ms +1940.00 ms 🔴 18.3%

site-startup

Metric trunk 2afcabe Diff Change
siteCreation 11041.00 ms 11994.00 ms +953.00 ms 🔴 8.6%
siteStartup 3923.00 ms 3960.00 ms +37.00 ms 🔴 0.9%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

ivan-ottinger
ivan-ottinger approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, Bernardo. I can confirm the links / buttons are now displaying correctly for sites with Classic themes now:

Markup on 2025-10-13 at 10:35:49

They also work as expected.

I did not observe any regressions and the links related to sites with block themes are also rendering and working correctly:

Markup on 2025-10-13 at 10:36:56

The proposed changes look good to me as well.

sejas
sejas approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that after creating a new site and changing the theme to Twenty Twenty, it displays the correct shortcuts to the customizer.

new-site-classic-theme.mp4

@sejas sejas merged commit 727ba1f into trunk Oct 13, 2025
14 checks passed
@sejas sejas deleted the stu-864-studio-using-classic-themes-does-not-displays-customize branch October 13, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sejas sejas sejas approved these changes

@ivan-ottinger ivan-ottinger ivan-ottinger approved these changes

Assignees

@bcotrim bcotrim

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bcotrim @sejas @ivan-ottinger