-
Notifications
You must be signed in to change notification settings - Fork 53
Add Beta Features menu #1860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Beta Features menu #1860
Conversation
bcotrim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described and a nice addition in my opinion!
LGTM 👍
|
@bcotrim Thank you for your review. Your Feature Flags menu implementation paved the way. 🥳 |
katinthehatsite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally, this works for me and I did not run into any issues 👍
I had one suggestion about the naming: to me, as a user with little context, it was not really clear what Studio Sites CLI did, especially since there was also Install CLI... command that was in the top menu. Perhaps we could improve the naming there
|
@katinthehatsite, do you see any short name we could use instead of the current one to make it more descriptive? Alternatively, we could use the menu description. It looks like that on macOS:
I'm unsure how it works on Windows, though. |
71d0094 to
bb91703
Compare
📊 Performance Test ResultsComparing 7efcaac vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
Oh I think this is very nice, let's do that. It would give users a brief idea of what the feature 👍 Worst case, we can try to limit it to Mac |
nightnei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| enableBlueprints: boolean; | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-empty-object-type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we don't need it. Also we can remove it from FeatureFlags.
| // eslint-disable-next-line @typescript-eslint/no-empty-object-type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't it left here to limit the number of changes we need to make when we remove the last feature flag?
src/lib/beta-features.ts
Outdated
| description?: string; | ||
| } | ||
|
|
||
| export const BETA_FEATURES_DEFINITION: Record< keyof BetaFeatures, BetaFeatureDefinition > = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it's not used outside
| export const BETA_FEATURES_DEFINITION: Record< keyof BetaFeatures, BetaFeatureDefinition > = { | |
| const BETA_FEATURES_DEFINITION: Record< keyof BetaFeatures, BetaFeatureDefinition > = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, removed in d4e7aaa.
src/lib/beta-features.ts
Outdated
| export const BETA_FEATURES: Record< keyof BetaFeatures, BetaFeatureDefinition > = | ||
| BETA_FEATURES_DEFINITION; | ||
|
|
||
| export function buildBetaFeatures( userData: BetaFeatures | undefined ): BetaFeatures { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| export function buildBetaFeatures( userData: BetaFeatures | undefined ): BetaFeatures { | |
| function buildBetaFeatures( userData: BetaFeatures | undefined ): BetaFeatures { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in d4e7aaa







Related issues
Proposed Changes
appdata-v1.jsonfor cross-app/CLI accessbetaFeatures.studioSitesClifrom appdata instead ofENABLE_CLI_V2environment variablestudio sitecommand when the beta feature is enabledTesting Instructions
Testing the Beta Features Menu
Testing CLI Integration
npm run makenode dist/cli/main.js --helpsitecommand is NOT listednode dist/cli/main.js --helpsite Manage local sites (Beta)command is now listednode dist/cli/main.js site listVerify Persistence
~/Library/Application Support/Studio/appdata-v1.json(macOS) or equivalent"betaFeatures": { "studioSitesCli": true }Pre-merge Checklist