Improve error displayed when pushing large site #1732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The warning is similar to the one being added on staging sites for a different purpose. Automattic/wp-calypso#105448 |
katinthehatsite
approved these changes
Sep 3, 2025
Contributor
katinthehatsite
left a comment
katinthehatsite
left a comment
There was a problem hiding this comment.
I think this works well, I did not spot any weird behaviours. I left one comment with a suggestion for visual improvements.
epeicher
approved these changes
Sep 4, 2025
Contributor
epeicher
left a comment
epeicher
left a comment
There was a problem hiding this comment.
Thanks Antonio for improving this! I have tested it, and I can see the error message indicating the size limit working as expected, also disabling the button. LGTM! 
| Over the limit | Less than the limit |
|---|---|
 |
 |
sejas
deleted the
update/stu-737-improve-error-displayed-when-pushing-large-site
branch
Contributor
|
@sejas, this is a great step to improve UX around the size limits. How does it work for the database? |
Member
Author
|
Thanks @wojtekn 🙌. |
Contributor
|
Thanks for the clarification, makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
npm startpush-selection-over-size-limit.mp4
Pre-merge Checklist