Skip to content

Keep export state to let user know what was completed #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wojtekn merged 4 commits into from
Aug 13, 2025
Merged

Keep export state to let user know what was completed #1657

wojtekn merged 4 commits into from
Aug 13, 2025

Conversation

@wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Aug 8, 2025

Related issues

Proposed Changes

I propose to keep the export state to let the user know what was completed. This is consistent with Pull and Push actions now.

Screenshot 2025-08-08 at 15 58 23 Screenshot 2025-08-08 at 15 58 14 Screenshot 2025-08-08 at 15 58 07

Testing Instructions

  1. Create two Studio sites
  2. Run the entire site export
  3. Confirm that progress is displayed and when it completes, success message is preserved
  4. Switch to another Studio site
  5. Run the site database export
  6. Confirm that progress is displayed and when it completes, success message is preserved
  7. Switch to the previous site, confirm that the state is still preserved
  8. Use Clear to remove the success state

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn requested a review from a team August 8, 2025 13:59
@wojtekn wojtekn self-assigned this Aug 8, 2025
sejas
sejas approved these changes Aug 12, 2025
View reviewed changes
Copy link
Member

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for persisting the export success message.
It works as expected, I tested it by exporting database and full site in different sites and I confirm the success message is persisted, and clears correctly when the user clicks on clear.

We can consider combining SyncPullPushClear and ExportClear into a generic component.

export-site-message.mp4

sejas
sejas approved these changes Aug 12, 2025
View reviewed changes
Copy link
Member

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wojtekn , for some reason the clear-action.tsx file was missing. I just added it 6cd6972 and tested the export and pull. Both work correctly. Thanks for making the changes ✨ .

@wojtekn
Copy link
Contributor Author

wojtekn commented Aug 13, 2025

Thanks for adding the file @sejas . It seems it was missing as git status didn't show the untracked file and I missed it in the commit. I checked it more, and found out that I had /src in my global .gitignore for some reason.

@wojtekn wojtekn merged commit fefb1d4 into trunk Aug 13, 2025
12 checks passed
@wojtekn wojtekn deleted the update/export-completed-state-handling branch August 13, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sejas sejas sejas approved these changes

Assignees

@wojtekn wojtekn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wojtekn @sejas