Skip to content

Allow logging out without triggering auth token deletion when offline #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ivan-ottinger merged 3 commits into from
Aug 6, 2025
Merged

Allow logging out without triggering auth token deletion when offline #1637

ivan-ottinger merged 3 commits into from
Aug 6, 2025

Conversation

@ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Aug 5, 2025

Related issues

Proposed Changes

  • ensure the Log out button is enabled even when offline
  • do not make auth token delete request when offline

Testing Instructions

  1. Check out the PR branch and build the app with npm start.
  2. Ensure you are logged in to your WordPress.com account in Studio.
  3. Go offline (e.g. by disabling wifi).
  4. Open Network tab in the Console.
  5. Click on your profile photo in the app header and try to log out. It should be possible.
  6. There should be no delete request to v2/studio-app/token made.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@ivan-ottinger ivan-ottinger self-assigned this Aug 5, 2025
@ivan-ottinger ivan-ottinger requested a review from a team August 5, 2025 10:37
epeicher
epeicher approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ivan! I have tested it, and it works as expected. I can log out but I don't see any request. LGTM! :shipit:

CleanShot.2025-08-05.at.12.49.36.mp4

gcsecsey
gcsecsey approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@gcsecsey gcsecsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ivan for quickly creating this fix. The changes look good to me, and I can see the request no longer being sent when offline. 👍 I can also see the log message about skipping the request as expected.

Image

@ivan-ottinger ivan-ottinger changed the title Remove Log out button block when offline Allow logging out without triggering auth token deletion when offline Aug 5, 2025
@ivan-ottinger ivan-ottinger merged commit 8bd53c0 into trunk Aug 6, 2025
12 checks passed
@ivan-ottinger ivan-ottinger deleted the remove/log-out-button-block-when-offline branch August 6, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epeicher epeicher epeicher approved these changes

@gcsecsey gcsecsey gcsecsey approved these changes

Assignees

@ivan-ottinger ivan-ottinger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ivan-ottinger @epeicher @gcsecsey @wojtekn