Update crash screen styling and fix crash #1599
Conversation
wojtekn
changed the title
| const { isRTL } = useI18n(); | ||
|
|
||
| useEffect( () => { | ||
| document.documentElement.dir = isRTL() ? 'rtl' : 'ltr'; |
There was a problem hiding this comment.
When Studio displays default error fallback, translations are not available, so it will always switch to LTR. We could even simplify this code and hardcode it to ltr. Any thoughts?
There was a problem hiding this comment.
I think it's better if we hard code it to LTR. That way we don't have "dead" code that won't work.
| } | ||
|
|
||
| const LOCKFILE_PATH = nodePath.join( getResourcesPath(), LOCKFILE_NAME ); | ||
| const LOCKFILE_PATH = getUserDataLockFilePath(); |
There was a problem hiding this comment.
I'm unsure why in #1319 we used two different locations for the app lock file. 🤔
There was a problem hiding this comment.
I like this improvement of using the same lock file function. But should it be a different PR?
There was a problem hiding this comment.
It's not only an improvement, but a fix for one of the bugs reported in STU-612. @ndiego reported layout issues on crash screen, but the crash in steps he shared shouldn't occur in the first place. The lock file location fixes that crash.
It would make sense to have two separate issues, but I addressed both as part of one PR, as both problems were reported under one issue and are related - one reproduces the other.
sejas
left a comment
sejas
left a comment
There was a problem hiding this comment.
Nice! Thanks for improving the crash window. I confirm I see the links correctly.
| Before | After |
|---|---|
 |
 |
In RTL I see the english text as expected:
I also see the expected error when trying to update Studio from a DMG image.
Related issues
Proposed Changes
Testing Instructions
Test crash screen styling
npm start)Before the fix, there was additional padding around the "contact support", it was black, and pointing to another page.
Test crash screen styling for RTL language
npm start)Before the fix, error screen was displayed in English but in RTL mode, with layout slightly broken. Additionally, the user couldn't close the trace with the mouse.
Test running Studio from read-only container
Before the fix, Studio running from read-only container was crashing when the site was started.
Pre-merge Checklist