Skip to content

Conversation

@wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Jul 16, 2025

Related issues

Proposed Changes

Currently, when users delete a site or create a new one, they are directed to the first site on the list or the new site, but the tab is preserved. Let's ensure that Studio displays the Overview tab in these cases.

Testing Instructions

Let's test a few cases.

Create site

  1. Open the Settings tab for a site
  2. Add a new site
  3. Confirm that the Overview of the new site is displayed

Delete site

  1. Open the Settings tab for a site
  2. Delete a site
  3. Confirm that the Overview of the first site is displayed

Create and switch site

  1. Open the Settings tab for a site
  2. Add a new site
  3. Quickly switch to another site
  4. Confirm that the current site and tab is preserved

Switch site

  1. Open the Settings tab for a site
  2. Switch site
  3. Confirm that the current tab is preserved

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn requested a review from a team July 16, 2025 14:53
@wojtekn wojtekn self-assigned this Jul 16, 2025
Copy link
Member

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and confirm these four behaviours.

  • New sites go to overview tab
  • When the new site is being created and the user changes the site, we don't switch the tab atuomatically
  • Deleting sites go to overview tab of another site.
  • Switching sites keep the same tab open
create-new-site-delete-site-go-to-overview-tab.mp4

@wojtekn wojtekn merged commit 5cec0a0 into trunk Jul 17, 2025
12 checks passed
@wojtekn wojtekn deleted the update/tab-handling-after-adding-and-deleteing-site branch July 17, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants