Skip to content

Conversation

@wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Jun 10, 2025

Related issues

Proposed Changes

  • I propose to escape backslash in the path opened by the terminal.

Testing Instructions

  • Test if terminal can be correctly opened at the site's path.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn requested a review from a team June 10, 2025 14:08
@wojtekn wojtekn self-assigned this Jun 10, 2025
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I can open the configured terminal at the correct Path. LGTM! :shipit:

CleanShot 2025-06-10 at 16 41 28@2x

Copy link
Contributor

@gcsecsey gcsecsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, and works well for pathnames with backslashes. 🚢

image

@wojtekn wojtekn merged commit 15fe492 into trunk Jun 10, 2025
12 checks passed
@wojtekn wojtekn deleted the fix/escaping-terminal-path branch June 10, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants