Follow symlink directories for Jetpack backups #1448
Conversation
epeicher
changed the title
epeicher
force-pushed
the
stu-392-studio-sync-include-symlink-directories-to-the-jetpack
branch
from
2b17c53 to
7ea8ef6
Compare
sejas
left a comment
sejas
left a comment
There was a problem hiding this comment.
This almost works as expected. I confirm the export includes/follow symlinks, but it's not excluding pathsToExclude and I see the sqlite-database-integration folder in the final zip.
I think we should remove the getSiteFiles but we can tackle that in a separate issue. I created STU-536.
| if ( entry.name.includes( '.git' ) || entry.name.includes( 'node_modules' ) ) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Let's also exclude the pathsToExclude.
Currently I see a regression where the sqlite-database-integration mu-plugin is being exported.
There was a problem hiding this comment.
Maybe if mu-plugins is empty we avoid adding it too 🤔
There was a problem hiding this comment.
Good catch! I have excluded them as part of 51c1983.
Maybe if mu-plugins is empty we avoid adding it too 🤔
A nice side effect is that empty directories are automatically excluded, for example, now that pathsToExclude filtering is applied, I cannot see either mu-plugins or fonts because they are empty in my site
I also thought about that and decided to suggest it as a follow-up, but you beat me to it 😄. Thank you very much for creating the task |
sejas
left a comment
sejas
left a comment
There was a problem hiding this comment.
Thanks for the update. It works great! Now the pathsToExclude paths are excluded, and the symlinks are resolved and included in the zip 👍 .
Before
export-with-symlinks-before.mp4
After
export-with-symlinks-after.mp4
…dio-sync-include-symlink-directories-to-the-jetpack
epeicher
deleted the
stu-392-studio-sync-include-symlink-directories-to-the-jetpack
branch
Related issues
Proposed Changes
archive.directoryinstead ofarchive.filefor creating the Jetpack backup file so the symlinks can be followed. This works because of the following patch in archiver.Testing Instructions
Export
Push
Pre-merge Checklist