Use same state for preview site usage and create preview site button #1385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekelund
approved these changes
May 13, 2025
Contributor
fredrikekelund
left a comment
fredrikekelund
left a comment
There was a problem hiding this comment.
Good catch 👍 I haven't tested it, but I can verify that this is the correct behavior.
Contributor
Author
|
We double-checked this with @wojtekn just now, and it seems that the root cause of the issue was the state mismatch here, the backend was counting active sites correctly. I went ahead and closed 182791-ghe-Automattic/wpcom now. |
ivan-ottinger
approved these changes
May 13, 2025
Contributor
ivan-ottinger
left a comment
ivan-ottinger
left a comment
There was a problem hiding this comment.
Nice find! The proposed change looks good and works as expected. 👌🏼
I was able to reproduce the issue with only one active preview site and the PR fixes it:
| Before | After |
|---|---|
 |
 |
wojtekn
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
While working on 182791-ghe-Automattic/wpcom I ran into the issue of not being able to add more preview sites. The Usage tab showed 9 sites but I couldn't press the
Create preview sitebutton to add a new one.create-preview-button.tsxto use the same state asuser-settings.tsxfor the number of active sitesTesting Instructions
Create preview sitebutton is enabledCreate preview sitebutton is disabledPre-merge Checklist