Skip to content

Conversation

@wojtekn
Copy link
Contributor

@wojtekn wojtekn commented May 13, 2025

Related issues

Proposed Changes

  • I propose deleting the https:// protocol from URLs in the UI. It will make the UI more readable.

Screenshot 2025-05-13 at 14 32 26

Screenshot 2025-05-13 at 14 32 13

Testing Instructions

  1. Start Studio
  2. Add site and navigate to the Sync tab
  3. Connect to the WordPress.com site
  4. Confirm that it doesn't show protocol on the list of connected sites and ensure it still points to the correct URL when clicked
  5. Navigate to the Previews tab
  6. Add a preview site
  7. Confirm it doesn't show protocol and ensure it still points to the correct URL when clicked

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn requested a review from a team May 13, 2025 12:51
@wojtekn wojtekn self-assigned this May 13, 2025
Copy link
Contributor

@gavande1 gavande1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a linting error. Apart from that, everything LGTM 👍
CleanShot 2025-05-13 at 19 23 55@2x

Copy link
Contributor

@gcsecsey gcsecsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me too, and work well. 👍

CleanShot 2025-05-13 at 17 06 19@2x

@wojtekn wojtekn merged commit b0e19fb into trunk May 13, 2025
8 checks passed
@wojtekn wojtekn deleted the delete/https-from-urls-in-ui branch May 13, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants