Studio CLI: Validate access token before starting command operation #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavande1
changed the title
epeicher
approved these changes
May 9, 2025
Contributor
epeicher
left a comment
epeicher
left a comment
There was a problem hiding this comment.
Thanks Rahul! I have tested this, and it works as expected. When modifying the token, the CLI returns the error as expected. LGTM!
Contributor
|
Nice improvement 👍 |
gavande1
deleted the
stu-464-studio-cli-doesnt-check-authentication-state-on-windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
This PR addresses the issue of invalid authentication states in Studio. Currently, the CLI uses the access token without first checking if it's still valid or has been revoked. To fix this, the PR adds a step to validate the access token by calling the
/meendpoint before starting any CLI process.Testing Instructions
Check out this branch.
Start the app:
Log in to your WordPress.com account.
Build the CLI:
Run the following command to create or list preview sites:
node dist/cli/main.js preview list --path ~/Studio/[SITE_NAME]Confirm that it lists existing preview sites. If none exist, create one.
Open your
appdata-v1.jsonfile, located at: "/Users/[YOUR_USER]/Library/Application Support/Studio/appdata-v1.json"Manually modify the
authToken.accessTokenvalue to an invalid token.Run the same CLI command again:
node dist/cli/main.js preview list --path ~/Studio/[SITE_NAME]The CLI should now return an authentication required message.
Pre-merge Checklist