Skip to content

What's New modal: Add badge to the modal, update illustration and remove the intro card #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ivan-ottinger merged 5 commits into from
May 2, 2025
Merged

What's New modal: Add badge to the modal, update illustration and remove the intro card #1312

ivan-ottinger merged 5 commits into from
May 2, 2025

Conversation

@ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented May 2, 2025 •
edited
Loading

Related issues

Proposed Changes

  • add "What's new" badge to the "What's New" modal
  • remove first ("intro") card from the "What's New" modal
  • update cli-illustration.svg illustration with minor position adjustment suited for the new "What's new" badge

Markup on 2025-05-02 at 10:17:08

Related design and discussion: STU-430-linear-issue#comment-a028b08b

Testing Instructions

  1. Check out the PR branch and build the app with npm start.
  2. In the top app menu, open the "What's New" modal by clicking on Help → What's New.
  3. Review the new "What's New" badge. It should render correctly.
  4. The newly-updated illustrations should look good as well.
  5. The modal and its new badge should render on the opposite site when RTL locale is selected.

Please note that the "What's New" modal misaligned X button in RTL is not related to this PR. We have a separate task for that issue: STU-351-linear-issue

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@ivan-ottinger ivan-ottinger self-assigned this May 2, 2025
@ivan-ottinger ivan-ottinger changed the title What's New modal: Add badge to the badge, update illustrations and remove the intro card What's New modal: Add badge to the badge, update illustration and remove the intro card May 2, 2025
@ivan-ottinger ivan-ottinger requested a review from a team May 2, 2025 08:28
@sejas sejas mentioned this pull request May 2, 2025
Merged
1 task
sejas
sejas approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@sejas sejas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it in both LTR and RTL languages, and it works great. I see the badge changing sides, and it doesn't overlap with any background image.

LTR RTL
ltr-1 rtl-1
ltr-2 rtl-2
ltr-3 rtl-3
ltr-4 rtl-4

@ivan-ottinger
Copy link
Contributor Author

ivan-ottinger commented May 2, 2025

I tested it in both LTR and RTL, and it works great. I see the badge changing sides, and it doesn't overlap with any background image.

Thank you for your review and testing, Antonio!

@ivan-ottinger ivan-ottinger merged commit dcc6f7d into trunk May 2, 2025
12 of 13 checks passed
@ivan-ottinger ivan-ottinger deleted the add/badge-to-whats-new-modal branch May 2, 2025 09:19
@ivan-ottinger ivan-ottinger changed the title What's New modal: Add badge to the badge, update illustration and remove the intro card What's New modal: Add badge to the modal, update illustration and remove the intro card May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sejas sejas sejas approved these changes

Assignees

@ivan-ottinger ivan-ottinger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivan-ottinger @sejas