Sync: Filter out a8c sites from the sync sites listing #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekn
approved these changes
Apr 23, 2025
Contributor
wojtekn
left a comment
wojtekn
left a comment
There was a problem hiding this comment.
The list of sites looks much cleaner now. 🥳
ivan-ottinger
changed the title
ivan-ottinger
deleted the
update/sync-sites-filering-to-exclude-a8c-sites
branch
bcotrim
reviewed
Apr 24, 2025
| } ); | ||
|
|
||
| const STUDIO_SYNC_FEATURE_NAME = 'studio-sync'; | ||
| const A8C_SITE_OWNER_ID = 26957695; |
Contributor
There was a problem hiding this comment.
I don't think exposing this ID is a good approach.
We also do it in calypso, but I believe it would be safer if we could handle this in the API instead.
Contributor
Author
There was a problem hiding this comment.
I was thinking about the same as well, but since I have seen the ID used in public Calypso repo already, I followed the same approach. Let's continue the discussion in STU-390-linear-issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
npm start.Connect sitebutton.Pre-merge Checklist