Fix JS error in About Studio dialog #1192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katinthehatsite
approved these changes
Apr 11, 2025
Contributor
katinthehatsite
left a comment
katinthehatsite
left a comment
There was a problem hiding this comment.
The changes look good and I could see the translations loading correctly for me:
gavande1
reviewed
Apr 11, 2025
Contributor
gavande1
left a comment
gavande1
left a comment
There was a problem hiding this comment.
The changes look good to me! 👍
sejas
approved these changes
Apr 11, 2025
Member
There was a problem hiding this comment.
Good catch!
I confirm I see the translations and I don't see any error when opening Electron → About Studio.
| English | Spanish |
|---|---|
 |
 |
This is the error I saw in the node console on trunk.
Error executing JavaScript: Error: Script failed to execute, this normally means an error was thrown. Check the renderer console for the error.
at node:electron/js2c/sandbox_bundle:2:127259
at IpcRendererInternal.<anonymous> (node:electron/js2c/sandbox_bundle:2:121504)
at IpcRendererInternal.emit (node:electron/js2c/sandbox_bundle:2:45997)
at Object.onMessage (node:electron/js2c/sandbox_bundle:2:119481)
Contributor
|
Thanks for the fix, Wojtek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
Pre-merge Checklist