Skip to content

Auto-start previously running sites on application launch #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sejas merged 8 commits into from
Apr 7, 2025
Merged

Auto-start previously running sites on application launch #1166

sejas merged 8 commits into from
Apr 7, 2025

Conversation

@sejas
Copy link
Member

@sejas sejas commented Apr 2, 2025 •
edited
Loading

Related issues

Proposed Changes

  • Added persistence of site running states across application restarts by saving autoStart site property into appData to track site were already running
  • Implemented automatic startup of previously running sites when application launches
  • Modified site server management to properly track and restore running states

Testing Instructions

  • Run npm start
  • Create a new site and make sure it starts
  • Close the application completely
  • Reopen the application
  • Verify the previously running site automatically starts up
  • Create a second site and stop it
  • Close and reopen the application
  • Confirm only the first site auto-starts while the second remains stopped
  • Stop the first site and restart the application
  • Verify it remains stopped, demonstrating the state is properly tracked
auto-start-previous-versions.mp4

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas self-assigned this Apr 2, 2025
@sejas sejas requested a review from a team April 7, 2025 10:45
katinthehatsite
katinthehatsite reviewed Apr 7, 2025
View reviewed changes
katinthehatsite
katinthehatsite approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I did not find any specific issues and the workflow worked as expected. I also liked that we were displaying "Starting" when the sites were starting. Nice work!!

@sejas sejas merged commit d132957 into trunk Apr 7, 2025
8 checks passed
@sejas sejas deleted the stu-321-studio-auto-start-previously-running-sites-on-application branch April 7, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katinthehatsite katinthehatsite katinthehatsite approved these changes

Assignees

@sejas sejas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sejas @katinthehatsite