Skip to content

Allow import/export while another site is syncing #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fredrikekelund merged 1 commit into from
Mar 18, 2025
Merged

Allow import/export while another site is syncing #1076

fredrikekelund merged 1 commit into from
Mar 18, 2025

Conversation

@fredrikekelund
Copy link
Contributor

@fredrikekelund fredrikekelund commented Mar 17, 2025

Related issues

Proposed Changes

  • Instead of disallowing import/export operations for all sites while any sync operation is in progress, disallow it only if the current site has an active sync operation.

Testing Instructions

  1. Have two Studio sites
  2. In the Sync tab, connect one of them to a WordPress.com site
  3. Initiate a pull or push operation
  4. Go to the Import/Export tab for that same site
  5. Ensure that the import and export controls are disabled
  6. Go to the Import/Export tab for the other site
  7. Ensure that the import and export controls are not disabled

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@fredrikekelund fredrikekelund requested a review from a team March 17, 2025 11:08
@fredrikekelund fredrikekelund self-assigned this Mar 17, 2025
katinthehatsite
katinthehatsite approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find any regressions. Works as expected 👍

ivan-ottinger
ivan-ottinger approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement. The proposed changes look good. It is now possible to import / export site when another one is being synced.

I did not observe any regressions.

@fredrikekelund fredrikekelund merged commit 8a47495 into trunk Mar 18, 2025
7 checks passed
@fredrikekelund fredrikekelund deleted the f26d/allow-import-export-when-other-site-syncing branch March 18, 2025 08:43
bgrgicak pushed a commit that referenced this pull request Mar 20, 2025
@fredrikekelund @bgrgicak
Allow import/export while another site is syncing (#1076)
f7c2387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivan-ottinger ivan-ottinger ivan-ottinger approved these changes

@katinthehatsite katinthehatsite katinthehatsite approved these changes

Assignees

@fredrikekelund fredrikekelund

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fredrikekelund @ivan-ottinger @katinthehatsite