Improve error message when port 80 is already in use #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-ottinger
force-pushed
the
update/another-server-running-error-message
branch
from
d3d2818 to
222e258
Compare
fredrikekelund
requested changes
Mar 14, 2025
Contributor
fredrikekelund
left a comment
fredrikekelund
left a comment
There was a problem hiding this comment.
Copy changes look good, but I realized there's an approach that doesn't require us to use a timeout.
Co-authored-by: Fredrik Rombach Ekelund <[email protected]>
wojtekn
approved these changes
Mar 17, 2025
1 task
bgrgicak
pushed a commit
that referenced
this pull request
Mar 20, 2025
* Delay error message * Update error message * Update copy Co-authored-by: Fredrik Rombach Ekelund <[email protected]> * Pass `mainWindow` instance to `dialog.showMessageBox` instead of using timeout --------- Co-authored-by: Fredrik Rombach Ekelund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
npm start.Pre-merge Checklist