Skip to content

Conversation

@wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Mar 10, 2025

Related issues

Proposed Changes

  • I propose to automatically start the site when a user opens it in the header using 'WP admin' or 'Open site' links or screenshot in the Overview tab.

Testing Instructions

  1. Ensure site is stopped
  2. Click 'WP admin', 'Open site' and screenshot
  3. Confirm each action starts and site and opens it

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn requested a review from a team March 10, 2025 16:32
Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes look good and work as expected. Clicking on the header links or site preview screenshot first starts the site. 👌🏼

One thing I would like to share is that with the currently proposed approach users might not notice that the site is starting. Instead of waiting for it to open, they might be motivated to click on those links again (multiple times) - as it may not be obvious the click went through correctly.

Clicking the link again before the site started opens it, but lands on the This site can’t be reached page.

I think that if we would like to autostart the site for the user, we could consider making it clearer that their click "went through" and is actually starting the site.

An alternative solution that comes to my mind could be disabling the links momentarily until the site is started and the site / WP Admin is getting opened.

What do you think? 🤔

@wojtekn
Copy link
Contributor Author

wojtekn commented Mar 11, 2025

Good catch @ivan-ottinger. I've experimented with loading indicators, but it looked overwhelming. I decided to disable buttons when the server is starting.

@ivan-ottinger ivan-ottinger self-requested a review March 11, 2025 14:43
Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The changes look good and work as intended.

All three buttons get disabled as soon as the server is starting. Once the server is running, the site or WP Admin gets opened right away.

I did not notice any regressions. Clicking the links when the site is already running works as before.

@wojtekn wojtekn self-assigned this Mar 13, 2025
@wojtekn wojtekn merged commit 462c4a5 into trunk Mar 13, 2025
8 checks passed
@wojtekn wojtekn deleted the add/auto-start-for-site-links branch March 13, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants