Skip to content

Conversation

@wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Mar 10, 2025

Related issues

  • Fixes p1741367797915539-slack-C06DRMD6VPZ

Proposed Changes

I propose to clean up tooltips:

  • Remove "Open URL" tooltips on links that already show URL and have an arrow that indicates it opens a link
  • Remove "Open URL" on buttons which already have descriptive texts
  • Remove "Open Settings" on links that is descriptive
  • Fix format date issue

Testing Instructions

  • Test if tooltips are removed and elements still work correctly.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn requested review from a team and matt-west March 10, 2025 09:50
@wojtekn wojtekn self-assigned this Mar 10, 2025
Copy link
Contributor

@matt-west matt-west left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better. Thanks @wojtekn

Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good and the related tooltips are no longer displaying. 👍🏼

The only thing I would like to mention is the case when the site URL is longer and the window is narrower, users then won't see it in full:

Markup on 2025-03-10 at 12:04:43

In that case they can either make the window wider or click the link.


Date format fix looks good as well.

@wojtekn wojtekn merged commit b07c331 into trunk Mar 10, 2025
7 checks passed
@wojtekn wojtekn deleted the update/cleanup-tooltips branch March 10, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants