CLI: Set UTF8 encoding for output on Windows (#1424)

fredrikekelund · web-flow · commit 43c831b86b2e · 2025-05-21T16:10:40.000+02:00
diff --git a/bin/studio-cli.bat b/bin/studio-cli.bat
@@ -1,7 +1,17 @@
 @echo off
 setlocal
 
+rem Save original code page
+for /f "tokens=2 delims=:" %%i in ('chcp') do set "ORIGINAL_CP=%%i"
+set ORIGINAL_CP=%ORIGINAL_CP: =%
+
+rem Set code page to UTF-8
+chcp 65001 >nul
+
 set ELECTRON_RUN_AS_NODE=1
 call "%~dp0..\..\Studio.exe" "%~dp0..\cli\main.js" %*
 
-endlocal 
+rem Restore original code page
+chcp %ORIGINAL_CP% >nul
+
+endlocal
diff --git a/src/modules/cli/lib/install-windows.ts b/src/modules/cli/lib/install-windows.ts
@@ -68,15 +68,11 @@ const installPath = async () => {
 };
 
 /**
- * Our app is installed in a versioned directory, so the
- * full path changes with every update. This makes it unreliable to add the
- * executable directly to the system PATH — we'd also need to handle cleaning up
- * outdated entries manually.
+ * Creates a proxy batch file in a stable location to handle CLI execution.
  *
- * To solve this, we generate a fixed entry point (a proxy script) in a
- * stable location within AppData, outside the versioned folder. This script
- * simply forwards execution to the current version’s actual CLI entry point.
- * On update, we just rewrite the proxy to point to the new version.
+ * Since our app is installed in a versioned directory, the full path changes with each update.
+ * Instead of adding the versioned executable directly to PATH, we create a fixed proxy script
+ * in the AppData directory that forwards execution to the current version's CLI entry point.
  */
 const installProxyBatFile = async () => {
 	try {
