Skip to content

Lesson details: Focus the title input on the form render #7802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bogiii merged 2 commits into from
Apr 1, 2025
Merged

Lesson details: Focus the title input on the form render #7802

bogiii merged 2 commits into from
Apr 1, 2025

Conversation

@bogiii
Copy link
Contributor

@bogiii bogiii commented Apr 1, 2025 •
edited
Loading

Proposed Changes

  • Autofocus the title input on the lesson details component render; matches behavior as the Course details screen.

Testing Instructions

  1. Go to the Sensei LMS plugin
  2. Click on Lessons -> New Lesson
  3. Check if the Title input is in focus
Screenshot 2025-04-01 at 12 52 20

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@bogiii bogiii self-assigned this Apr 1, 2025
@bogiii bogiii requested a review from a team April 1, 2025 10:53
@bogiii bogiii added this to the 4.24.6 milestone Apr 1, 2025
@bogiii bogiii marked this pull request as ready for review April 1, 2025 10:54
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

Test the previous changes of this PR with WordPress Playground.

@github-actions
Copy link

github-actions bot commented Apr 1, 2025 •
edited
Loading

WordPress Dependencies Report

The github-action-wordpress-dependencies-report action has detected some script changes between the commit 32d654b and trunk. Please review and confirm the following are correct before merging.

Script Handle Added Dependencies Removed Dependencies Total Size Size Diff
admin/editor-wizard/index.js 13 kB -1 B ( -0.01% ⬇️ )

This comment was automatically generated by the github-action-wordpress-dependencies-report action.

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

Test the previous changes of this PR with WordPress Playground.

m1r0
m1r0 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bogiii bogiii merged commit acf5e5a into trunk Apr 1, 2025
22 checks passed
@bogiii bogiii deleted the update/lesson-details-form branch April 1, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m1r0 m1r0 m1r0 approved these changes

Assignees

@bogiii bogiii

Labels

None yet

Projects

None yet

Milestone

4.25.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bogiii @m1r0