Skip to content

Wizard newsletter form: Handle server error #7801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bogiii merged 2 commits into from
Apr 2, 2025
Merged

Wizard newsletter form: Handle server error #7801

bogiii merged 2 commits into from
Apr 2, 2025

Conversation

@bogiii
Copy link
Contributor

@bogiii bogiii commented Apr 1, 2025

Resolves #7756

Proposed Changes

  • Handle server errors and show the message

Testing Instructions

  1. Enter the setup wizard when installing Sensei LMS for the first time or go to Sensei LMS -> Courses -> Help (top right) -> Setup wizard
  2. Go to the newsletter step and try to submit your email
  3. Check for the error message "Failed to connect to the server. Please try again later."
  4. It happens because of MailChimp's free plan, which doesn't allow API integration; check: Setup Wizard: Newsletter signup is not working #7756 (comment)
Screenshot 2025-04-01 at 12 35 31

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@bogiii bogiii added this to the 4.24.6 milestone Apr 1, 2025
@bogiii bogiii requested a review from a team April 1, 2025 10:36
@bogiii bogiii self-assigned this Apr 1, 2025
@bogiii bogiii mentioned this pull request Apr 1, 2025
Open
@bogiii bogiii marked this pull request as ready for review April 1, 2025 10:39
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

Test the previous changes of this PR with WordPress Playground.

@github-actions
Copy link

github-actions bot commented Apr 1, 2025 •
edited
Loading

WordPress Dependencies Report

The github-action-wordpress-dependencies-report action has detected some script changes between the commit e243868 and trunk. Please review and confirm the following are correct before merging.

Script Handle Added Dependencies Removed Dependencies Total Size Size Diff
setup-wizard/index.js 17.5 kB +52 B ( +0.3% 🔼 )

This comment was automatically generated by the github-action-wordpress-dependencies-report action.

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

Test the previous changes of this PR with WordPress Playground.

merkushin
merkushin approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 👍

@bogiii bogiii merged commit 6afe1c2 into trunk Apr 2, 2025
22 checks passed
@bogiii bogiii deleted the update/wizard-newsletter-form branch April 2, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@merkushin merkushin merkushin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bogiii bogiii

Labels

None yet

Projects

None yet

Milestone

4.25.0

Development

Successfully merging this pull request may close these issues.

Setup Wizard: Newsletter signup is not working

3 participants

@bogiii @merkushin