Skip to content

Conversation

@Imran92
Copy link
Contributor

@Imran92 Imran92 commented Mar 26, 2025

Resolves #7682

Proposed Changes

  • Show the title from the archive page instead of showing a hardcoded title

Testing Instructions

  1. Go to Sensei LMS -> Settings (General) and check which page is selected as the Courses archive page
  2. Open that page and make sure there is Course List block in that page
  3. Edit the title
  4. Now open your course archive pages (siteurl.local/courses-overview)
  5. Make sure you see the edited title
  6. Try the filters and make sure you still see the same edited title
  7. Now remove the Course List block from the archive page. We are doing it so that the forced archive page template takes over
  8. Now open the archive page from the frontend again
  9. Make sure the title is the hardcoded one this time
  10. Try the filters and make sure you see the different hardcoded filters there for different filters instead of the edited one.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@Imran92 Imran92 added this to the 4.24.6 milestone Mar 26, 2025
@Imran92 Imran92 requested a review from a team March 26, 2025 01:30
@Imran92 Imran92 self-assigned this Mar 26, 2025
@github-actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions
Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've followed the testing instructions. Everything works as described.

The only thing I'm not 100% sure is about the filtering point:

Try the filters and make sure you see the different hardcoded filters there for different filters instead of the edited one.

Do you mean page filtering?
Screenshot 2025-03-26 at 11 34 37

@bogiii bogiii self-requested a review March 26, 2025 11:31
Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a chat with @Imran92 in DM and he explained to me what to expect with the filters.
Confirming, it works as described. 👌

@Imran92 Imran92 merged commit ed9c463 into trunk Mar 27, 2025
22 checks passed
@Imran92 Imran92 deleted the fix/show-template-title-on-course-archive branch March 27, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Courses page does not show the title of the selected archive page, rather shows a fixed static string "Courses"

3 participants