Skip to content

Fix plugin configure link pointing to a non-existing settings tab #7781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
m1r0 merged 1 commit into from
Mar 24, 2025
Merged

Fix plugin configure link pointing to a non-existing settings tab #7781

m1r0 merged 1 commit into from
Mar 24, 2025

Conversation

@m1r0
Copy link
Member

@m1r0 m1r0 commented Mar 21, 2025 •
edited
Loading

Proposed Changes

  • Fixes the "Configure" link pointing to a non-existing settings tab.

Testing Instructions

  1. Go to the installed plugins list and find Sensei LMS.
  2. Click the "Configure" link
  3. You should be redirected to "/admin.php?page=sensei-settings" and see all the settings from the "General" tab.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@m1r0 m1r0 added this to the 4.24.6 milestone Mar 21, 2025
@m1r0 m1r0 self-assigned this Mar 21, 2025
@m1r0 m1r0 requested a review from a team March 21, 2025 17:23
@github-actions
Copy link

github-actions bot commented Mar 21, 2025

Test the previous changes of this PR with WordPress Playground.

bogiii
bogiii approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@m1r0 m1r0 merged commit 2abdef9 into trunk Mar 24, 2025
23 checks passed
@m1r0 m1r0 deleted the fix/settings-link branch March 24, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogiii bogiii bogiii approved these changes

Assignees

@m1r0 m1r0

Labels

None yet

Projects

None yet

Milestone

4.25.0

Development

Successfully merging this pull request may close these issues.

3 participants

@m1r0 @bogiii