Fix early translation in the tracking class #7780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test the previous changes of this PR with WordPress Playground. |
m1r0
force-pushed
the
fix/early-translations-in-tracking
branch
from
2652426 to
132ee10
Compare
|
Test the previous changes of this PR with WordPress Playground. |
m1r0
force-pushed
the
fix/early-translations-in-tracking
branch
from
132ee10 to
3b84567
Compare
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
m1r0
commented
Mar 21, 2025
| * @access private | ||
| */ | ||
| public function register_course_list_block_patterns() { | ||
| require __DIR__ . '/course-list/class-sensei-course-list-block-patterns.php'; |
Member
Author
There was a problem hiding this comment.
This file is already loaded by the composer autoloader, so there's no need to require it again. It was causing a Fatal error: Cannot declare class Sensei_Course_List_Block_Patterns, because the name is already in use when testing using multiple do_action( 'init' ) calls (check the tests code).
renatho
approved these changes
Mar 24, 2025
Contributor
renatho
left a comment
renatho
left a comment
There was a problem hiding this comment.
Looks good and works well!
Also confirmed that the data is sent correctly when running the event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7701 and #7770
Proposed Changes
sensei_usage_tracking_send_usage_datacron schedule is added. The error is also visible when activating Sensei Pro for the first time. The issue is solved by moving the cron schedule initialization to theinithook, which is a somewhat standard practice. As a side effect, this approach also forces thewp_schedule_eventto be called oninitas well.Testing Instructions
On WordPress 6.8 the deprecation notice can be seen even when the language is English. For ease of testing, the testing instructions target this version.
sensei_usage_tracking_send_usage_datacron and delete it.PHP Notice: Function _load_textdomain_just_in_time was called incorrectly.sensei_usage_tracking_send_usage_datajob is re-created.Pre-Merge Checklist