Prevent storing enrolment data in memory on Students screen #7772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
renatho
approved these changes
Mar 18, 2025
Contributor
renatho
left a comment
renatho
left a comment
There was a problem hiding this comment.
Thank you for solving this quickly! This works as described! =)
|
|
||
| return $manual_enrolment_provider->is_enrolled( $user_id, $this->course_id ); | ||
| // Reset the enrolment state store to avoid out of memory issues. | ||
| // TODO: This can be removed once the state store no longer holds all the data in memory. |
Contributor
There was a problem hiding this comment.
once the state store no longer holds all the data in memory.
Do we have an issue to implement this already?
Member
Author
There was a problem hiding this comment.
Thanks for the review, Renatho! I'm not sure. It's possible that the Sensei_Enrolment_Provider_State_Store is storing everything in memory to avoid querying the database multiple times per request. I didn't have the time to investigate all the cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/Automattic/sensei-pro/issues/2640
Proposed Changes
Testing Instructions
Sensei_Enrolment_Provider_State_Store::persist_allmethod to inspect the$instancesproperty. Note that this method is called on theshutdownaction so just adding avar_dump(self::$instances)should work as well./wp-admin/admin.php?page=sensei_learners&course_id=578669&view=learners&enrolment_status=manual)$instancesproperty is empty.Pre-Merge Checklist