Skip to content

Conversation

@pkevan
Copy link
Contributor

@pkevan pkevan commented Feb 26, 2025

Since the underlying get_comments function can return an empty array, check it before returning the value.

Fixes #7754.

Resolves #7754

Since the underlying `get_comments` function can return an empty array, check it before returning the value.

Fixes #7754.
@github-actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@m1r0 m1r0 added this to the 4.24.6 milestone Feb 26, 2025
@github-actions
Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you!! I did just one small correction to make Psalm happy.

@m1r0 m1r0 merged commit 0a442b6 into trunk Feb 26, 2025
22 checks passed
@m1r0 m1r0 deleted the fix/7754 branch February 26, 2025 16:52
@pkevan
Copy link
Contributor Author

pkevan commented Feb 26, 2025

This looks good, thank you!! I did just one small correction to make Psalm happy.

No problem, and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP8 Fatal during Quiz submission; $answer is null.

3 participants