Skip to content

Conversation

@Imran92
Copy link
Contributor

@Imran92 Imran92 commented Feb 19, 2025

Resolves #7681

Proposed Changes

  • Adds a "Disabled" indicator text following "Draft" is shown on Posts and Pages list of WordPress

Testing Instructions

  1. Go to Sensei LMS -> Settings -> Emails
  2. Disable one or more email
  3. Make sure you see a "- Disabled" string at the end of the email titles
  4. Make sure you don't see it when the emails are enabled

I'm having some issues with tests, so will add that separately.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@Imran92 Imran92 requested a review from a team February 19, 2025 21:37
@Imran92 Imran92 self-assigned this Feb 19, 2025
@github-actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@merkushin merkushin added this to the 4.24.6 milestone Feb 20, 2025
merkushin
merkushin previously approved these changes Feb 20, 2025
Copy link
Contributor

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! 👍

Just checking—will you be adding a changelog entry here?

@github-actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@Imran92 Imran92 merged commit 4c06947 into trunk Feb 24, 2025
22 checks passed
@Imran92 Imran92 deleted the fix/email-status-display branch February 24, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it easier to visually understand which emails are enabled/disabled

3 participants