Skip to content

Initialize Sensei blocks for new posts #7736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
donnapep merged 3 commits into from
Jan 15, 2025
Merged

Initialize Sensei blocks for new posts #7736

donnapep merged 3 commits into from
Jan 15, 2025

Conversation

@donnapep
Copy link
Collaborator

@donnapep donnapep commented Jan 14, 2025 •
edited
Loading

Resolves #7734.
Rregression from #6823.

Proposed Changes

The conditional check assumed that all new posts would have the post_type query parameter, but that is not true for posts. This PR handles that use case.

Testing Instructions

  1. Create a new post.
  2. Open the inserter and check that Sensei blocks are there, including Course List.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@donnapep donnapep added the [Failure] Product Failure resulting from an incorrect / missed business requirement label Jan 14, 2025
@donnapep donnapep added this to the 4.24.5 milestone Jan 14, 2025
@donnapep donnapep self-assigned this Jan 14, 2025
@github-actions
Copy link

github-actions bot commented Jan 14, 2025

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep requested a review from a team January 14, 2025 20:49
@github-actions
Copy link

github-actions bot commented Jan 14, 2025

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep removed the [Failure] Product Failure resulting from an incorrect / missed business requirement label Jan 14, 2025
merkushin
merkushin approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@donnapep donnapep merged commit fbcb785 into trunk Jan 15, 2025
23 checks passed
@donnapep donnapep deleted the fix/no-sensei-blocks-for-posts branch January 15, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@merkushin merkushin merkushin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@donnapep donnapep

Labels

None yet

Projects

None yet

Milestone

4.24.5

Development

Successfully merging this pull request may close these issues.

Sensei Blocks not available in Posts

3 participants

@donnapep @merkushin