Skip to content

Conversation

@donnapep
Copy link
Collaborator

@donnapep donnapep commented Jan 13, 2025

Resolves https://github.com/Automattic/sensei-security/issues/21.

Proposed Changes

Switch to using wp_json_encode instead of json_encode when searching courses on the Module admin page.

Testing Instructions

  1. Browse to Sensei LMS > Modules.
  2. Search for a course in the Course(s) dropdown and ensure it works.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@donnapep donnapep added this to the 4.24.5 milestone Jan 13, 2025
@donnapep donnapep self-assigned this Jan 13, 2025
@donnapep donnapep changed the title Switch to using wp_json_encode instead of json_encode on Modules page Switch to using wp_json_encode instead of json_encode in Modules admin Jan 13, 2025
@github-actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep requested review from m1r0 and merkushin January 13, 2025 17:12
Copy link
Contributor

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@donnapep donnapep merged commit e8bfc57 into trunk Jan 14, 2025
23 checks passed
@donnapep donnapep deleted the update/json_encode-to-wp_json_encode branch January 14, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants