Skip to content

Update the course/lesson placeholder to use an internal image #7728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
m1r0 merged 2 commits into from
Jan 13, 2025
Merged

Update the course/lesson placeholder to use an internal image #7728

m1r0 merged 2 commits into from
Jan 13, 2025

Conversation

@m1r0
Copy link
Member

@m1r0 m1r0 commented Jan 13, 2025 •
edited
Loading

Resolves https://github.com/Automattic/sensei-security/issues/27

Proposed Changes

  • Update the placeholder to use an internal image instead of an external one (via.placeholder.com).

Testing Instructions

  1. Go to Sensei LMS -> Settings -> General and enable the "Use placeholder images" option.
  2. Go to Sensei LMS -> Settings -> Lessons and enable the "Single Lesson Images" option.
  3. Go to the courses archive page and make sure the course placeholder is visible.
  4. Go to a single lesson page and make sure the lesson placeholder is visible.
image image

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@m1r0 m1r0 added this to the 4.24.5 milestone Jan 13, 2025
@m1r0 m1r0 self-assigned this Jan 13, 2025
@m1r0 m1r0 marked this pull request as ready for review January 13, 2025 15:13
@github-actions
Copy link

github-actions bot commented Jan 13, 2025

Test the previous changes of this PR with WordPress Playground.

@m1r0 m1r0 requested a review from donnapep January 13, 2025 15:22
donnapep
donnapep approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@donnapep donnapep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this hasn't worked for some time as via.placeholder.com isn't a valid site. But these images only seem to display when Learning Mode is disabled and the course archive page isn't using blocks, so likely minimal impact.

@m1r0 m1r0 merged commit 0d90ab1 into trunk Jan 13, 2025
23 checks passed
@m1r0 m1r0 deleted the update/placeholder-image branch January 13, 2025 17:14
@donnapep donnapep changed the title Update the course/lesson placeholder to use in internal image Update the course/lesson placeholder to use an internal image Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@donnapep donnapep donnapep approved these changes

Assignees

@m1r0 m1r0

Labels

None yet

Projects

None yet

Milestone

4.24.5

Development

Successfully merging this pull request may close these issues.

3 participants

@m1r0 @donnapep