Skip to content

GUID normalisation bug, leading to duplicates #15

@Alkarex

Description

@Alkarex

Hello,
This plug-in is performing an hardcoded URL normalisation of GUIDs from https:// to http://:

$feed_urls[$k] = str_replace( 'https://', 'http://', $url );

But the articles themselves in the corresponding RSS feeds have GUIDs using https://.

This leads to duplicate in clients subscribing to those feeds because articles exist with two different GUIDs:

FreshRSS/FreshRSS#5151 (comment)

At the very least, the normalisation should be made the other way around, now that a majority of WordPress blogs run HTTPS, including WordPress.org, but a better approach would be desirable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions