Repository navigation
fix(model): stop Model.validate() crashing on missing nested objects - #16600
Merged
vkarpov15 merged 1 commit intoOct 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Give a schema a path three levels deep, like
profile.address.city, andModel.validate({ name: 'x' })rejects withTypeError: Cannot read properties of undefined (reading 'address')instead of validating.Model['~standard'].validate()goes through the same code, so it hands that TypeError back as the only issue for input thats perfectly valid.The loop that throws walks down to each path's parent and never reads what it finds (
castObject()does the writing back now), so I've just taken it out.Examples
Added a test with no
profileat all. On master it gets the TypeError, with this it gets therequirederror forprofile.address.city.