Skip to content

InferSchemaType: consider { required: boolean } required if it isn't explicitly false #12784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vkarpov15 merged 2 commits into from
Dec 16, 2022
Merged

InferSchemaType: consider { required: boolean } required if it isn't explicitly false #12784

vkarpov15 merged 2 commits into from
Dec 16, 2022

Conversation

@JavaScriptBach
Copy link
Contributor

@JavaScriptBach JavaScriptBach commented Dec 9, 2022 •
edited
Loading

Summary

Fixes #12782

Examples

Added a test

@JavaScriptBach JavaScriptBach marked this pull request as ready for review December 9, 2022 05:16
@Uzlopak
Copy link
Collaborator

Uzlopak commented Dec 9, 2022

You forgot the typings tests.

vkarpov15
vkarpov15 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.8.1 milestone Dec 16, 2022
@vkarpov15 vkarpov15 merged commit 45c82e8 into Automattic:master Dec 16, 2022
@vkarpov15 vkarpov15 mentioned this pull request Aug 7, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.8.1

Development

Successfully merging this pull request may close these issues.

InferSchemaType: Improve type safety by inferring {required: boolean} as a required field instead of optional

3 participants

@JavaScriptBach @Uzlopak @vkarpov15