Skip to content

Conversation

@oskosk
Copy link
Contributor

@oskosk oskosk commented Mar 26, 2018

Fixes positioning of popovers when the window is resized

Mirrors Automattic/wp-calypso#19992

Props to @AnnaMag and @eliorivero

Changes proposed in this Pull Request:

  • Defers setting the new position on the popover until next tick.

Testing instructions:

  • On a connected Jetpack site, Checkout this branch
  • Build the admin page
  • Get the Jetpack Settings.
  • Click the InfoPopover links and expect to see the popover properly positioned.
  • Narrow the window , close and reopen the Popovers and expect them to be well positioned.

Proposed changelog entry for your changes:

  • Fixed the positioning of popovers in Jetpack Settings page.

@oskosk oskosk added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Changelog labels Mar 26, 2018
@oskosk oskosk added this to the 6.0 milestone Mar 26, 2018
@oskosk oskosk requested a review from a team as a code owner March 26, 2018 13:52
@oskosk oskosk requested a review from eliorivero March 26, 2018 13:52
@oskosk
Copy link
Contributor Author

oskosk commented Mar 26, 2018

@eliorivero would you mind checking this one ?

@eliorivero
Copy link
Contributor

Works beautifully 🐑

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 26, 2018
@oskosk oskosk merged commit 7d4e285 into master Mar 26, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 26, 2018
@oskosk oskosk deleted the fix/popover-positioning branch March 26, 2018 16:51
oskosk added a commit that referenced this pull request Mar 26, 2018
dereksmart pushed a commit that referenced this pull request Mar 27, 2018
* Changelog 6.0: create base for changelog.

* Add #8938 to changelog

* Add #8962 to changelog

* Add #8974 to changelog

* Add #8975 to changelog

* Add #8978 to changelog

* Add #8867 to changelog

* Add #8937 to changelog

* Add #8961 to changelog

* Add #8855 to changelog

* Add #8944 to changelog

* Add #8973 to changelog

* Add #8977 to changelog

* Add #8979 to changelog

* Add #8980 to changelog

* Add #8982 to changelog

* Add #8983 to changelog

* Add #8984 to changelog

* Add #8986 to changelog

* Add #9005 to changelog

* Add #9010 to changelog

* Add #9012 to changelog

* Add #9021 to changelog

* Add #9022 to changelog

* Add #9056 to changelog

* Add #9061 to changelog

* Add #9079 to changelog

* Add #9080 to changelog

* Add #9088 to changelog

* Add #9096 to changelog

* Add #9097 to changelog

* Add #9100 to changelog

* Add #9107 to changelog

* Add #8969 to changelog

* Add #8993 to changelog

* Add #9003 to changelog

* Add #9031 to changelog

* Add #8945 to changelog

* Add #9052 to changelog

* Add #9058 to changelog

* Add #9066 to changelog

* Add #9076 to changelog

* Add #9053 to changelog

* Add #9108 to changelog

* Add #9135 to changelog

* Add #9148 to changelog

* Add #9125 to changelog

* Add #9137 to changelog

* Added testing instructions for 6.0.

* Added IS testing instructions, huge props to @tiagonoronha.

* Added #8498 to changelog.

* Added #8954 to changelog.

* Added #8985 to changelog.

* add #9027

* add #9112 to changelog

* add #9136 to changelog

* add #9102 to changelog

* add #9093 to changelog

* add #9062 to changelog

* add #9172 to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants